derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

stdlib: Improve handing of errors in Atlas request failures (#404)

Browse Source 
Now:

* The Atlas Client will attempt a connection 4 times, using an
exponential backoff approach between attempts.
* When a failure does arise a rich output is given so problems can be
easily diagnosed.

Addresses: #340
This commit is contained in:
Bobby R. Bruce
2023-10-10 21:34:24 -07:00
committed by GitHub
parent ad2fe42686 bbc301f2f0
commit d559c24ac2
4 changed files with 121 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
tests/pyunit/stdlib/resources/pyunit_client_wrapper_checks.py
View File

@@ -34,6 +34,10 @@ import io
import contextlib
from pathlib import Path
from gem5.resources.client_api.atlasclient import (
AtlasClientHttpJsonRequestError,
)
mock_json_path = Path(__file__).parent / "refs/resources.json"
mock_config_json = {
"sources": {
@@ -419,21 +423,11 @@ class ClientWrapperTestSuite(unittest.TestCase):
@patch("urllib.request.urlopen", side_effect=mocked_requests_post)
def test_invalid_auth_url(self, mock_get):
resource_id = "test-resource"
f = io.StringIO()
with self.assertRaises(Exception) as context:
with contextlib.redirect_stderr(f):
get_resource_json_obj(
resource_id,
gem5_version="develop",
)
self.assertTrue(
"Error getting resources from client gem5-resources:"
" Panic: Not found" in str(f.getvalue())
)
self.assertTrue(
"Resource with ID 'test-resource' not found."
in str(context.exception)
)
with self.assertRaises(AtlasClientHttpJsonRequestError) as context:
get_resource_json_obj(
resource_id,
gem5_version="develop",
)
@patch(
"gem5.resources.client.clientwrapper",
@@ -442,21 +436,11 @@ class ClientWrapperTestSuite(unittest.TestCase):
@patch("urllib.request.urlopen", side_effect=mocked_requests_post)
def test_invalid_url(self, mock_get):
resource_id = "test-resource"
f = io.StringIO()
with self.assertRaises(Exception) as context:
with contextlib.redirect_stderr(f):
get_resource_json_obj(
resource_id,
gem5_version="develop",
)
self.assertTrue(
"Error getting resources from client gem5-resources:"
" Panic: Not found" in str(f.getvalue())
)
self.assertTrue(
"Resource with ID 'test-resource' not found."
in str(context.exception)
)
with self.assertRaises(AtlasClientHttpJsonRequestError) as context:
get_resource_json_obj(
resource_id,
gem5_version="develop",
)
@patch(
"gem5.resources.client.clientwrapper",
@@ -465,18 +449,8 @@ class ClientWrapperTestSuite(unittest.TestCase):
@patch("urllib.request.urlopen", side_effect=mocked_requests_post)
def test_invalid_url(self, mock_get):
resource_id = "test-too-many"
f = io.StringIO()
with self.assertRaises(Exception) as context:
with contextlib.redirect_stderr(f):
get_resource_json_obj(
resource_id,
gem5_version="develop",
)
self.assertTrue(
"Error getting resources from client gem5-resources:"
" Panic: Too many requests" in str(f.getvalue())
)
self.assertTrue(
"Resource with ID 'test-too-many' not found."
in str(context.exception)
)
with self.assertRaises(AtlasClientHttpJsonRequestError) as context:
get_resource_json_obj(
resource_id,
gem5_version="develop",
)