mem: Set the cache line size on a system level
This patch removes the notion of a peer block size and instead sets the cache line size on the system level. Previously the size was set per cache, and communicated through the interconnect. There were plenty checks to ensure that everyone had the same size specified, and these checks are now removed. Another benefit that is not yet harnessed is that the cache line size is now known at construction time, rather than after the port binding. Hence, the block size can be locally stored and does not have to be queried every time it is used. A follow-on patch updates the configuration scripts accordingly.
This commit is contained in:
@@ -163,7 +163,7 @@ DmaPort::dmaAction(Packet::Command cmd, Addr addr, int size, Event *event,
|
||||
|
||||
DPRINTF(DMA, "Starting DMA for addr: %#x size: %d sched: %d\n", addr, size,
|
||||
event ? event->scheduled() : -1);
|
||||
for (ChunkGenerator gen(addr, size, peerBlockSize());
|
||||
for (ChunkGenerator gen(addr, size, sys->cacheLineSize());
|
||||
!gen.done(); gen.next()) {
|
||||
Request *req = new Request(gen.addr(), gen.size(), flag, masterId);
|
||||
PacketPtr pkt = new Packet(req, cmd);
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright (c) 2012 ARM Limited
|
||||
* Copyright (c) 2012-2013 ARM Limited
|
||||
* All rights reserved.
|
||||
*
|
||||
* The license below extends only to copyright in the software and shall
|
||||
@@ -49,6 +49,7 @@
|
||||
#include "dev/io_device.hh"
|
||||
#include "params/DmaDevice.hh"
|
||||
#include "sim/drain.hh"
|
||||
#include "sim/system.hh"
|
||||
|
||||
class DmaPort : public MasterPort
|
||||
{
|
||||
@@ -146,7 +147,6 @@ class DmaPort : public MasterPort
|
||||
|
||||
bool dmaPending() const { return pendingCount > 0; }
|
||||
|
||||
unsigned cacheBlockSize() const { return peerBlockSize(); }
|
||||
unsigned int drain(DrainManager *drainManger);
|
||||
};
|
||||
|
||||
@@ -178,7 +178,7 @@ class DmaDevice : public PioDevice
|
||||
|
||||
unsigned int drain(DrainManager *drainManger);
|
||||
|
||||
unsigned cacheBlockSize() const { return dmaPort.cacheBlockSize(); }
|
||||
unsigned int cacheBlockSize() const { return sys->cacheLineSize(); }
|
||||
|
||||
virtual BaseMasterPort &getMasterPort(const std::string &if_name,
|
||||
PortID idx = InvalidPortID);
|
||||
|
||||
Reference in New Issue
Block a user