From cfa028291e036c06d65608de903b3f1dd3d4f334 Mon Sep 17 00:00:00 2001 From: Hoa Nguyen Date: Mon, 7 Jun 2021 12:21:05 -0700 Subject: [PATCH] util: Make sorted includes verifier less confusing verifiers.py complains about unordered includes where there is more than one empty line under the #include region, even if the includes are sorted. This change adds a note about the fact. Change-Id: I7a8dbc12fd82db0f0cadcfec270e42f6e0de4aea Signed-off-by: Hoa Nguyen Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/46580 Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power Tested-by: kokoro --- util/style/verifiers.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/util/style/verifiers.py b/util/style/verifiers.py index efc347eb17..7ab7344636 100644 --- a/util/style/verifiers.py +++ b/util/style/verifiers.py @@ -361,8 +361,10 @@ class SortedIncludes(Verifier): if modified: if not silent: - self.ui.write("invalid sorting of includes in %s\n" - % (filename)) + self.ui.write("invalid sorting of includes in %s. Note: If " + "there is more than one empty line under the " + "#include region, please reduce it to one.\n" + % (filename)) if self.ui.verbose: for start, end in modified.regions: self.ui.write("bad region [%d, %d)\n" % (start, end))