From bb9539ad4d037e83e2f7a9ae61318d467af602ac Mon Sep 17 00:00:00 2001 From: Matthew Poremba Date: Thu, 29 Aug 2024 09:20:25 -0700 Subject: [PATCH] arch-vega: Revert incorrect SOPC compare (#1521) LT <= was previously correct while < is not. Can lead to incorrect program execution. Related to #1366 related to #1520 Change-Id: I00b7838e920eee7c8adb508e869fdf53a9373e1f --- src/arch/amdgpu/vega/insts/sopc.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/arch/amdgpu/vega/insts/sopc.cc b/src/arch/amdgpu/vega/insts/sopc.cc index 3c6c7c1b89..a29060ca3f 100644 --- a/src/arch/amdgpu/vega/insts/sopc.cc +++ b/src/arch/amdgpu/vega/insts/sopc.cc @@ -368,7 +368,7 @@ namespace VegaISA src0.read(); src1.read(); - scc = (src0.rawData() < src1.rawData()) ? 1 : 0; + scc = (src0.rawData() <= src1.rawData()) ? 1 : 0; scc.write(); } // execute