From ba1473f2a9be61ed2ad3ec87c9d4394b97727110 Mon Sep 17 00:00:00 2001 From: Giacomo Travaglini Date: Wed, 28 Apr 2021 18:20:23 +0100 Subject: [PATCH] arch-riscv, arch-x86: Define unique PageTableWalker flag Rather than defining multiple flags (one per ISA), we should define a single PageTableWalker flag shared by all ISAs Change-Id: Iad460bcd9a69d5c6f90443e43feec318429165aa Signed-off-by: Giacomo Travaglini Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/44965 Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power Tested-by: kokoro --- src/arch/generic/SConscript | 2 ++ src/arch/riscv/SConscript | 2 -- src/arch/x86/SConscript | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/arch/generic/SConscript b/src/arch/generic/SConscript index 3ad4878ccc..fb144f9988 100644 --- a/src/arch/generic/SConscript +++ b/src/arch/generic/SConscript @@ -47,6 +47,8 @@ SimObject('BaseMMU.py') SimObject('BaseTLB.py') SimObject('ISACommon.py') +DebugFlag('PageTableWalker', + "Page table walker state machine debugging") DebugFlag('TLB') if env['TARGET_ISA'] == 'null': diff --git a/src/arch/riscv/SConscript b/src/arch/riscv/SConscript index 03e382ceaa..291499c56d 100644 --- a/src/arch/riscv/SConscript +++ b/src/arch/riscv/SConscript @@ -75,8 +75,6 @@ if env['TARGET_ISA'] == 'riscv': DebugFlag('RiscvMisc') DebugFlag('TLBVerbose') DebugFlag('PMP') - DebugFlag('PageTableWalker', \ - "Page table walker state machine debugging") # Add in files generated by the ISA description. ISADesc('isa/main.isa') diff --git a/src/arch/x86/SConscript b/src/arch/x86/SConscript index f790ec19b6..d7da2903bd 100644 --- a/src/arch/x86/SConscript +++ b/src/arch/x86/SConscript @@ -77,8 +77,6 @@ SimObject('X86TLB.py') DebugFlag('Faults', "Trace all faults/exceptions/traps") DebugFlag('LocalApic', "Local APIC debugging") -DebugFlag('PageTableWalker', \ - "Page table walker state machine debugging") DebugFlag('Decoder', "Decoder debug output") DebugFlag('X86', "Generic X86 ISA debugging")