From b7720a09952c8ecdf768603648c7e139876bf94b Mon Sep 17 00:00:00 2001 From: Giacomo Travaglini Date: Wed, 20 Jul 2022 09:33:42 +0100 Subject: [PATCH] arch-arm: MISCREG_IMPDEF_UNIMPL does not need unimplemented flag The decode tree is checking for MISCREG_IMPDEF_UNIMPL before the MISCREG_UNIMPLEMENTED flag Faulting is handled anyway by the new fault callbacks Change-Id: I600ac02913c2fd947c3a6b7f1f81111f21bff3f6 Signed-off-by: Giacomo Travaglini Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/61687 Maintainer: Andreas Sandberg Reviewed-by: Richard Cooper Reviewed-by: Andreas Sandberg Tested-by: kokoro --- src/arch/arm/regs/misc.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/arch/arm/regs/misc.cc b/src/arch/arm/regs/misc.cc index 6f6b179e2e..8cf64d136a 100644 --- a/src/arch/arm/regs/misc.cc +++ b/src/arch/arm/regs/misc.cc @@ -4933,7 +4933,6 @@ ISA::initializeMiscRegMetadata() .allPrivileges().exceptUserMode().writes(0); InitReg(MISCREG_UNKNOWN); InitReg(MISCREG_IMPDEF_UNIMPL) - .unimplemented() .fault(EL1, faultImpdefUnimplEL1) .fault(EL2, faultUnimplemented) .fault(EL3, faultUnimplemented)