From a315df2dd855a5e6c7be385d7c77d2a68ba79d09 Mon Sep 17 00:00:00 2001 From: "Bobby R. Bruce" Date: Fri, 21 Jan 2022 11:56:34 -0800 Subject: [PATCH] tests: Add x86 mutlicore boot tests for timing CPUs Due to a spin lock error affecting multicore timing cores, https://gem5.atlassian.net/browse/GEM5-1105, gem5 only supported single-core timing setups. As this has now been fixed, we support it. This patch expands the boot tests to include tests for multicore timing CPU systems. Change-Id: I89b7f1bed077373dae5e9b8eb6818129da915fee Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/55744 Reviewed-by: Austin Harris Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power Maintainer: Bobby Bruce Tested-by: kokoro --- tests/gem5/x86-boot-tests/test_linux_boot.py | 30 ++++++++++++++++---- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/tests/gem5/x86-boot-tests/test_linux_boot.py b/tests/gem5/x86-boot-tests/test_linux_boot.py index 77d1c0dfc4..4b66541a6a 100644 --- a/tests/gem5/x86-boot-tests/test_linux_boot.py +++ b/tests/gem5/x86-boot-tests/test_linux_boot.py @@ -125,6 +125,15 @@ test_boot( length=constants.quick_tag, ) +test_boot( + cpu="timing", + num_cpus=8, + mem_system="classic", + memory_class="SingleChannelDDR3_2133", + to_tick=10000000000, + length=constants.quick_tag, +) + test_boot( cpu="atomic", num_cpus=4, @@ -172,6 +181,15 @@ test_boot( length=constants.long_tag, ) +test_boot( + cpu="timing", + num_cpus=4, + mem_system="classic", + memory_class="DualChannelDDR3_2133", + boot_type="init", + length=constants.long_tag, +) + test_boot( cpu="atomic", num_cpus=4, @@ -224,15 +242,15 @@ run_map = { }, "timing": { 1: True, - 2: False, # Timeout - 4: False, # Timeout - 8: False, # Timeout + 2: True, + 4: True, + 8: True, }, "o3": { 1: False, # Timeout - 2: False, # Not Supported - 4: False, # Not Supported - 8: False, # Not Supported + 2: False, # Timeout + 4: False, # Timeout + 8: False, # Timeout }, }, "mi_example": {