From 9ffcf154714c6c8594bd0eca7234ba78e414e95a Mon Sep 17 00:00:00 2001 From: Giacomo Travaglini Date: Sun, 14 Mar 2021 21:59:19 +0000 Subject: [PATCH] dev-arm: Remove unused SMMUv3 WalkCache variables Those were grouped within the stats data structures but were not actually stats Signed-off-by: Giacomo Travaglini Change-Id: I01bbbada423825ded04a033c0709108e2980ec70 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/42985 Reviewed-by: Jason Lowe-Power Reviewed-by: Hoa Nguyen Maintainer: Jason Lowe-Power Tested-by: kokoro --- src/dev/arm/smmu_v3_caches.cc | 3 --- src/dev/arm/smmu_v3_caches.hh | 3 --- 2 files changed, 6 deletions(-) diff --git a/src/dev/arm/smmu_v3_caches.cc b/src/dev/arm/smmu_v3_caches.cc index b09fb31e72..069e0702a2 100644 --- a/src/dev/arm/smmu_v3_caches.cc +++ b/src/dev/arm/smmu_v3_caches.cc @@ -1043,10 +1043,8 @@ WalkCache::lookup(Addr va, Addr vaMask, if (result == NULL) baseCacheStats.totalMisses++; - walkCacheStats.lookupsByStageLevel[stage-1][level]++; walkCacheStats.totalLookupsByStageLevel[stage-1][level]++; if (result == NULL) { - walkCacheStats.missesByStageLevel[stage-1][level]++; walkCacheStats.totalMissesByStageLevel[stage-1][level]++; } } @@ -1079,7 +1077,6 @@ WalkCache::store(const Entry &incoming) } baseCacheStats.totalUpdates++; - walkCacheStats.updatesByStageLevel[incoming.stage-1][incoming.level]++; walkCacheStats .totalUpdatesByStageLevel[incoming.stage-1][incoming.level]++; } diff --git a/src/dev/arm/smmu_v3_caches.hh b/src/dev/arm/smmu_v3_caches.hh index 07c6242d75..a6faf6a89d 100644 --- a/src/dev/arm/smmu_v3_caches.hh +++ b/src/dev/arm/smmu_v3_caches.hh @@ -327,15 +327,12 @@ class WalkCache : public SMMUv3BaseCache WalkCacheStats(Stats::Group *parent); ~WalkCacheStats(); - unsigned int lookupsByStageLevel[2][WALK_CACHE_LEVELS]; std::vector averageLookupsByStageLevel; Stats::Vector2d totalLookupsByStageLevel; - unsigned int missesByStageLevel[2][WALK_CACHE_LEVELS]; std::vector averageMissesByStageLevel; Stats::Vector2d totalMissesByStageLevel; - unsigned int updatesByStageLevel[2][WALK_CACHE_LEVELS]; std::vector averageUpdatesByStageLevel; Stats::Vector2d totalUpdatesByStageLevel;