derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

arch-x86: Fix wrong x86 assembly (#251)

Browse Source 
The RM field of ModRM was printed as Reg field for several instructions.

For reference, this change fixes typos introduced by [1].

[1] https://gem5-review.googlesource.com/c/public/gem5/+/40339
This commit is contained in:
Bobby R. Bruce
2023-09-01 00:26:00 -07:00
committed by GitHub
parent 4de4e22553 4ff1f160ec
commit 8d47cda8b6
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/arch/x86/isa/specialize.isa
View File

@@ -240,7 +240,7 @@ let {{
regFormat = \
"printReg(out, intRegClass[%s], regSize);\n"
regSuffix = "_R"
env.addToDisassembly(regFormat % ModRMRegIndex)
env.addToDisassembly(regFormat % ModRMRMIndex)
return doSplitDecode("MODRM_MOD",
{"3" : (specializeInst, Name + regSuffix,
copy.copy(opTypes), regEnv)},
@@ -268,7 +268,7 @@ let {{
regFormat = \
"printReg(out, intRegClass[%s], regSize);\n"
Name += "_R"
env.addToDisassembly(regFormat % ModRMRegIndex)
env.addToDisassembly(regFormat % ModRMRMIndex)
elif opType.tag in ("X", "Y"):
# This type of memory addressing is for string instructions.
# They'll use the right index and segment internally.