derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sim-se: Fix tgkill logic bug in handling signal argument

Browse Source 
The syscall emulation of tgkill contained a simple logic bug
(a `||` instead of a `&&`), causing the signal argument to always
be considered invalid. This patch fixes the bug by simply changing
the `||` to a `&&`.

GitHub issue: https://github.com/gem5/gem5/issues/284

Change-Id: I3b02c618c369ef56d32a0b04e0b13eacc9fb4977
This commit is contained in:
Nicholas Mosier
2023-09-07 14:17:32 -07:00
committed by Nicholas Mosier
parent ebde1133c0
commit 8740385f9e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sim/syscall_emul.hh
View File

@@ -2409,7 +2409,7 @@ tgkillFunc(SyscallDesc *desc, ThreadContext *tc, int tgid, int tid, int sig)
}
}
if (sig != 0 || sig != OS::TGT_SIGABRT)
if (sig != 0 && sig != OS::TGT_SIGABRT)
return -EINVAL;
if (tgt_proc == nullptr)