From 7d9cf53e78bd8b3b2c0ff323880c921b9931e2fe Mon Sep 17 00:00:00 2001 From: "Bobby R. Bruce" Date: Thu, 26 Aug 2021 13:05:48 -0700 Subject: [PATCH] configs: Fix AbstractGeneratorCore connect_interrupt sig `interrupt_requestor` and `interrupt_responce` are not manditory, they should be defaulted to None. Without this errors occur when attempting to call `connect_interrupt`. Change-Id: I9401132df681b9a19eede8808a9a68d435cc5bbe Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49610 Tested-by: kokoro Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power --- components_library/processors/abstract_generator_core.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/components_library/processors/abstract_generator_core.py b/components_library/processors/abstract_generator_core.py index 969c94ac1d..226dfa6c76 100644 --- a/components_library/processors/abstract_generator_core.py +++ b/components_library/processors/abstract_generator_core.py @@ -31,6 +31,8 @@ from ..utils.override import overrides from .cpu_types import CPUTypes from .abstract_core import AbstractCore +from typing import Optional + class AbstractGeneratorCore(AbstractCore): """The abstract generator core @@ -82,7 +84,9 @@ class AbstractGeneratorCore(AbstractCore): @overrides(AbstractCore) def connect_interrupt( - self, interrupt_requestor: Port, interrupt_responce: Port + self, + interrupt_requestor: Optional[Port] = None, + interrupt_responce: Optional[Port] = None, ) -> None: """ Since generator cores are not used in full system mode, no need to