gcc: Clean-up of non-C++0x compliant code, first steps
This patch cleans up a number of minor issues aiming to get closer to compliance with the C++0x standard as interpreted by gcc and clang (compile with std=c++0x and -pedantic-errors). In particular, the patch cleans up enums where the last item was succeded by a comma, namespaces closed by a curcly brace followed by a semi-colon, and the use of the GNU-extension typeof (replaced by templated functions). It does not address variable-length arrays, zero-size arrays, anonymous structs, range expressions in switch statements, and the use of long long. The generated CPU code also has a large number of issues that remain to be fixed, mainly related to overflows in implicit constant conversion (due to shifts).
This commit is contained in:
@@ -42,7 +42,7 @@
|
||||
#include "base/types.hh"
|
||||
|
||||
// This lets us figure out what the byte order of the host system is
|
||||
#if defined(linux)
|
||||
#if defined(__linux__)
|
||||
#include <endian.h>
|
||||
// If this is a linux system, lets used the optimized definitions if they exist.
|
||||
// If one doesn't exist, we pretty much get what is listed below, so it all
|
||||
@@ -65,7 +65,7 @@ enum ByteOrder {BigEndianByteOrder, LittleEndianByteOrder};
|
||||
inline uint64_t
|
||||
swap_byte64(uint64_t x)
|
||||
{
|
||||
#if defined(linux)
|
||||
#if defined(__linux__)
|
||||
return bswap_64(x);
|
||||
#elif defined(__APPLE__)
|
||||
return OSSwapInt64(x);
|
||||
@@ -84,7 +84,7 @@ swap_byte64(uint64_t x)
|
||||
inline uint32_t
|
||||
swap_byte32(uint32_t x)
|
||||
{
|
||||
#if defined(linux)
|
||||
#if defined(__linux__)
|
||||
return bswap_32(x);
|
||||
#elif defined(__APPLE__)
|
||||
return OSSwapInt32(x);
|
||||
@@ -98,7 +98,7 @@ swap_byte32(uint32_t x)
|
||||
inline uint16_t
|
||||
swap_byte16(uint16_t x)
|
||||
{
|
||||
#if defined(linux)
|
||||
#if defined(__linux__)
|
||||
return bswap_16(x);
|
||||
#elif defined(__APPLE__)
|
||||
return OSSwapInt16(x);
|
||||
|
||||
Reference in New Issue
Block a user