From 9ec7a1c14a1aa232533bbf1899ff2f21b462af26 Mon Sep 17 00:00:00 2001 From: Hoa Nguyen Date: Wed, 26 Jul 2023 19:20:13 -0700 Subject: [PATCH 1/2] util: Ignore line length check for #include pragma in C/C++ files The length of the path of the #include pragma can be more than 79-character long. Change-Id: Id72250c166370c7f456bd1f7d05589a49c14c33d Signed-off-by: Hoa Nguyen --- src/sst/sst_responder_interface.hh | 2 +- util/style/verifiers.py | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/sst/sst_responder_interface.hh b/src/sst/sst_responder_interface.hh index 0e827abfdc..eb9c72ef64 100644 --- a/src/sst/sst_responder_interface.hh +++ b/src/sst/sst_responder_interface.hh @@ -30,7 +30,7 @@ #include -#include "mem/port.hh" +#include "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaamem/port.hh" /** * SSTResponderInterface provides an interface specified gem5's expectations diff --git a/util/style/verifiers.py b/util/style/verifiers.py index dbcce1c764..7a88e59789 100644 --- a/util/style/verifiers.py +++ b/util/style/verifiers.py @@ -424,7 +424,11 @@ class LineLength(LineVerifier): test_name = "line length" opt_name = "length" - def check_line(self, line, **kwargs): + def check_line(self, line, language, **kwargs): + # Ignore line length check for include pragmas of C/C++. + if language in {"C", "C++"}: + if line.startswith("#include"): + return True return style.normalized_len(line) <= 79 def fix(self, filename, regions=all_regions, **kwargs): From f19945e9cbcf742611125fc357210d10d59a76f2 Mon Sep 17 00:00:00 2001 From: Hoa Nguyen Date: Wed, 26 Jul 2023 21:29:00 -0700 Subject: [PATCH 2/2] ext: Remove the test Change-Id: I5c174ad388f63e7846dab5d9497ab2faa73ca6f7 Signed-off-by: Hoa Nguyen --- src/sst/sst_responder_interface.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sst/sst_responder_interface.hh b/src/sst/sst_responder_interface.hh index eb9c72ef64..0e827abfdc 100644 --- a/src/sst/sst_responder_interface.hh +++ b/src/sst/sst_responder_interface.hh @@ -30,7 +30,7 @@ #include -#include "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaamem/port.hh" +#include "mem/port.hh" /** * SSTResponderInterface provides an interface specified gem5's expectations