From 58bc790a0909c54dec4e8dc8a6257358f581bb50 Mon Sep 17 00:00:00 2001
From: Giacomo Travaglini <giacomo.travaglini@arm.com>
Date: Fri, 18 Oct 2024 12:21:04 +0100
Subject: [PATCH] arch-arm: Do not include tlb.hh in mmu.hh

This commit is moving some MMU methods definition in the
source file from the header to avoid including tlb.hh

Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Change-Id: I8fb1aeccd9c38c48b09583b4dc5d152acd09c3e6
---
 src/arch/arm/mmu.cc | 77 ++++++++++++++++++++++++++++++++++++++
 src/arch/arm/mmu.hh | 90 ++++++---------------------------------------
 2 files changed, 89 insertions(+), 78 deletions(-)

diff --git a/src/arch/arm/mmu.cc b/src/arch/arm/mmu.cc
index fd25bb248f..61d1211238 100644
--- a/src/arch/arm/mmu.cc
+++ b/src/arch/arm/mmu.cc
@@ -45,6 +45,7 @@
 #include "arch/arm/reg_abi.hh"
 #include "arch/arm/stage2_lookup.hh"
 #include "arch/arm/table_walker.hh"
+#include "arch/arm/tlb.hh"
 #include "arch/arm/tlbi_op.hh"
 #include "debug/TLB.hh"
 #include "debug/TLBVerbose.hh"
@@ -134,6 +135,18 @@ MMU::drainResume()
     s2State.miscRegValid = false;
 }
 
+ArmISA::TLB *
+MMU::getDTBPtr() const
+{
+    return static_cast<ArmISA::TLB *>(dtb);
+}
+
+ArmISA::TLB *
+MMU::getITBPtr() const
+{
+    return static_cast<ArmISA::TLB *>(itb);
+}
+
 TLB *
 MMU::getTlb(BaseMMU::Mode mode, bool stage2) const
 {
@@ -200,6 +213,70 @@ MMU::invalidateMiscReg()
     s2State.computeAddrTop.flush();
 }
 
+void
+MMU::flush(const TLBIOp &tlbi_op)
+{
+    if (tlbi_op.stage1Flush()) {
+        flushStage1(tlbi_op);
+    }
+
+    if (tlbi_op.stage2Flush()) {
+        flushStage2(tlbi_op);
+    }
+}
+
+void
+MMU::flushStage1(const TLBIOp &tlbi_op)
+{
+    for (auto tlb : instruction) {
+        static_cast<TLB*>(tlb)->flush(tlbi_op);
+    }
+    for (auto tlb : data) {
+        static_cast<TLB*>(tlb)->flush(tlbi_op);
+    }
+    for (auto tlb : unified) {
+        static_cast<TLB*>(tlb)->flush(tlbi_op);
+    }
+}
+
+void
+MMU::flushStage2(const TLBIOp &tlbi_op)
+{
+    itbStage2->flush(tlbi_op);
+    dtbStage2->flush(tlbi_op);
+}
+
+void
+MMU::iflush(const TLBIOp &tlbi_op)
+{
+    for (auto tlb : instruction) {
+        static_cast<TLB*>(tlb)->flush(tlbi_op);
+    }
+    for (auto tlb : unified) {
+        static_cast<TLB*>(tlb)->flush(tlbi_op);
+    }
+}
+
+void
+MMU::dflush(const TLBIOp &tlbi_op)
+{
+    for (auto tlb : data) {
+        static_cast<TLB*>(tlb)->flush(tlbi_op);
+    }
+    for (auto tlb : unified) {
+        static_cast<TLB*>(tlb)->flush(tlbi_op);
+    }
+}
+
+void
+MMU::flushAll()
+{
+    BaseMMU::flushAll();
+    itbStage2->flushAll();
+    dtbStage2->flushAll();
+}
+
+
 Fault
 MMU::testAndFinalize(const RequestPtr &req,
                      ThreadContext *tc, Mode mode,
diff --git a/src/arch/arm/mmu.hh b/src/arch/arm/mmu.hh
index 54ff852246..921b335cc4 100644
--- a/src/arch/arm/mmu.hh
+++ b/src/arch/arm/mmu.hh
@@ -42,7 +42,6 @@
 #define __ARCH_ARM_MMU_HH__
 
 #include "arch/arm/page_size.hh"
-#include "arch/arm/tlb.hh"
 #include "arch/arm/utility.hh"
 #include "arch/generic/mmu.hh"
 #include "base/memoizer.hh"
@@ -57,23 +56,18 @@ namespace gem5
 namespace ArmISA {
 
 class TableWalker;
+class TLB;
+class TlbEntry;
+class TLBIOp;
+class TlbTestInterface;
 
 class MMU : public BaseMMU
 {
   protected:
     using LookupLevel = enums::ArmLookupLevel;
 
-    ArmISA::TLB *
-    getDTBPtr() const
-    {
-        return static_cast<ArmISA::TLB *>(dtb);
-    }
-
-    ArmISA::TLB *
-    getITBPtr() const
-    {
-        return static_cast<ArmISA::TLB *>(itb);
-    }
+    ArmISA::TLB * getDTBPtr() const;
+    ArmISA::TLB * getITBPtr() const;
 
     TLB * getTlb(BaseMMU::Mode mode, bool stage2) const;
     TableWalker * getTableWalker(BaseMMU::Mode mode, bool stage2) const;
@@ -298,73 +292,13 @@ class MMU : public BaseMMU
 
     void invalidateMiscReg();
 
-    template <typename OP>
-    void
-    flush(const OP &tlbi_op)
-    {
-        if (tlbi_op.stage1Flush()) {
-            flushStage1(tlbi_op);
-        }
+    void flush(const TLBIOp &tlbi_op);
+    void flushStage1(const TLBIOp &tlbi_op);
+    void flushStage2(const TLBIOp &tlbi_op);
+    void iflush(const TLBIOp &tlbi_op);
+    void dflush(const TLBIOp &tlbi_op);
 
-        if (tlbi_op.stage2Flush()) {
-            flushStage2(tlbi_op);
-        }
-    }
-
-    template <typename OP>
-    void
-    flushStage1(const OP &tlbi_op)
-    {
-        for (auto tlb : instruction) {
-            static_cast<TLB*>(tlb)->flush(tlbi_op);
-        }
-        for (auto tlb : data) {
-            static_cast<TLB*>(tlb)->flush(tlbi_op);
-        }
-        for (auto tlb : unified) {
-            static_cast<TLB*>(tlb)->flush(tlbi_op);
-        }
-    }
-
-    template <typename OP>
-    void
-    flushStage2(const OP &tlbi_op)
-    {
-        itbStage2->flush(tlbi_op);
-        dtbStage2->flush(tlbi_op);
-    }
-
-    template <typename OP>
-    void
-    iflush(const OP &tlbi_op)
-    {
-        for (auto tlb : instruction) {
-            static_cast<TLB*>(tlb)->flush(tlbi_op);
-        }
-        for (auto tlb : unified) {
-            static_cast<TLB*>(tlb)->flush(tlbi_op);
-        }
-    }
-
-    template <typename OP>
-    void
-    dflush(const OP &tlbi_op)
-    {
-        for (auto tlb : data) {
-            static_cast<TLB*>(tlb)->flush(tlbi_op);
-        }
-        for (auto tlb : unified) {
-            static_cast<TLB*>(tlb)->flush(tlbi_op);
-        }
-    }
-
-    void
-    flushAll() override
-    {
-        BaseMMU::flushAll();
-        itbStage2->flushAll();
-        dtbStage2->flushAll();
-    }
+    void flushAll() override;
 
     uint64_t
     getAttr() const