misc: Appease GCC 8

GCC 8 adds a number of new warnings to -Wall which generate errors.

- Fix memset to 0 for structs by adding casts.
- Fix cast with const when the const was ignored.
- Fix catch a polymorphic type by value

We now compile with GCC 8!

Change-Id: Iab70ce11190eee67608fc25c0bedff170152b153
Signed-off-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-on: https://gem5-review.googlesource.com/11949
Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>

src/dev/storage/ide_ctrl.cc

@@ -83,7 +83,7 @@ IdeController::Channel::Channel(
     cmdAddr(0), cmdSize(_cmdSize), ctrlAddr(0), ctrlSize(_ctrlSize),
     master(NULL), slave(NULL), selected(NULL)
 {
-    memset(&bmiRegs, 0, sizeof(bmiRegs));
+    bmiRegs.reset();
     bmiRegs.status.dmaCap0 = 1;
     bmiRegs.status.dmaCap1 = 1;
 }

src/dev/storage/ide_ctrl.hh

@@ -81,6 +81,10 @@ class IdeController : public PciDevice
         /** Registers used for bus master interface */
         struct BMIRegs
         {
+            void reset() {
+                memset(static_cast<void *>(this), 0, sizeof(*this));
+            }
+
             BMICommandReg command;
             uint8_t reserved0;
             BMIStatusReg status;