From 4b3ba1daa628b14213c3b42c853f62268db58ebd Mon Sep 17 00:00:00 2001 From: "Bobby R. Bruce" Date: Thu, 22 Aug 2024 05:08:19 -0700 Subject: [PATCH] stdlib: Deprecate Simulator 'full_system' param THis is deprecated in favor of the board determining whether the simulation is FS or SE. Usually this will be contingent on which `set_workload` funciton has been called. Regardless, it is the board's responsibility. The user should not need to explicitly declare this any longer. --- src/python/gem5/simulate/simulator.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/python/gem5/simulate/simulator.py b/src/python/gem5/simulate/simulator.py index 49dfac2bdf..59385fe17d 100644 --- a/src/python/gem5/simulate/simulator.py +++ b/src/python/gem5/simulate/simulator.py @@ -117,6 +117,10 @@ class Simulator: behavior. If not set, whether or not to run in FS mode will be determined via the board's ``is_fullsystem()`` function. + **Warning: This parameter is deprecated. The board + determines if the simulation is full system or not. + This parameter will be removed in a future gem5 + release.** :param on_exit_event: An optional map to specify what to execute on each exit event. There are three possibilities here: a generator, a list of functions, or a single function. @@ -291,6 +295,15 @@ class Simulator: """ + if full_system is not None: + warn( + "Setting the full_system parameter via the Simulator " + "constructor is deprecated and will be removed in future " + "releases of gem5. " + "The board determines if the simulation is full system or not " + "via it's `is_fullsystem` method." + ) + self.set_max_ticks(max_ticks) if id: