From 3f5cab5a9d62bb42400ff3296f0ab77afe1f3d59 Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Fri, 29 Oct 2021 01:45:41 -0700 Subject: [PATCH] cpu: Remove an architecture check in addPrivateSplitL1Caches. If there are iwc and dwc parameters, then they need to be hooked up. If not, then they don't. There's no need to check the ISA as well. Change-Id: I98cb831ab6d3f829ccab80e128105245e434a35c Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/52488 Reviewed-by: Giacomo Travaglini Maintainer: Giacomo Travaglini Tested-by: kokoro --- src/cpu/BaseCPU.py | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/src/cpu/BaseCPU.py b/src/cpu/BaseCPU.py index 1fa4d9e717..4814745fda 100644 --- a/src/cpu/BaseCPU.py +++ b/src/cpu/BaseCPU.py @@ -208,22 +208,21 @@ class BaseCPU(ClockedObject): self.icache_port = ic.cpu_side self.dcache_port = dc.cpu_side self._cached_ports = ['icache.mem_side', 'dcache.mem_side'] - if buildEnv['TARGET_ISA'] in ['x86', 'arm', 'riscv']: - if iwc and dwc: - self.itb_walker_cache = iwc - self.dtb_walker_cache = dwc - self.mmu.connectWalkerPorts( - iwc.cpu_side, dwc.cpu_side) - self._cached_ports += ["itb_walker_cache.mem_side", \ - "dtb_walker_cache.mem_side"] - else: - self._cached_ports += ArchMMU.walkerPorts() + if iwc and dwc: + self.itb_walker_cache = iwc + self.dtb_walker_cache = dwc + self.mmu.connectWalkerPorts( + iwc.cpu_side, dwc.cpu_side) + self._cached_ports += ["itb_walker_cache.mem_side", \ + "dtb_walker_cache.mem_side"] + else: + self._cached_ports += ArchMMU.walkerPorts() - # Checker doesn't need its own tlb caches because it does - # functional accesses only - if self.checker != NULL: - self._cached_ports += [ "checker." + port - for port in ArchMMU.walkerPorts() ] + # Checker doesn't need its own tlb caches because it does + # functional accesses only + if self.checker != NULL: + self._cached_ports += [ "checker." + port + for port in ArchMMU.walkerPorts() ] def addTwoLevelCacheHierarchy(self, ic, dc, l2c, iwc=None, dwc=None, xbar=None):