From 223cd52431747d6b686507d98f07ff03a7e5a2ad Mon Sep 17 00:00:00 2001 From: Kyle Roarty Date: Thu, 4 Nov 2021 18:09:07 -0500 Subject: [PATCH] arch-gcn3,arch-vega: Don't write exec in v_cmp_f_i32 Per the GCN3 and VEGA ISAs, v_cmpx_* writes exec, while v_cmp_* doesn't. This removes the erroneous exec write in the VOP3 implementation of v_cmp_f_i32. Change-Id: I048e35917163c45b879f38d31a88f3f3d56c0baf Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/52445 Maintainer: Matt Sinclair Reviewed-by: Matt Sinclair Reviewed-by: Matthew Poremba Tested-by: kokoro --- src/arch/amdgpu/gcn3/insts/instructions.cc | 1 - src/arch/amdgpu/vega/insts/instructions.cc | 1 - 2 files changed, 2 deletions(-) diff --git a/src/arch/amdgpu/gcn3/insts/instructions.cc b/src/arch/amdgpu/gcn3/insts/instructions.cc index 65d008bbc7..bb15957c92 100644 --- a/src/arch/amdgpu/gcn3/insts/instructions.cc +++ b/src/arch/amdgpu/gcn3/insts/instructions.cc @@ -20601,7 +20601,6 @@ namespace Gcn3ISA } } - wf->execMask() = sdst.rawData(); sdst.write(); } diff --git a/src/arch/amdgpu/vega/insts/instructions.cc b/src/arch/amdgpu/vega/insts/instructions.cc index 757bfa84a3..1e07f0b6d5 100644 --- a/src/arch/amdgpu/vega/insts/instructions.cc +++ b/src/arch/amdgpu/vega/insts/instructions.cc @@ -22454,7 +22454,6 @@ namespace VegaISA } } - wf->execMask() = sdst.rawData(); sdst.write(); } // execute // --- Inst_VOP3__V_CMP_LT_I32 class methods ---