derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dev-arm, system-arm: Remove HDLcd from VExpress_GEM5_VX platforms

Browse Source 
This is a major change in our platform configuration.
At the moment the VExpress_GEM5_V1 and VExpress_GEM5_V2 platforms
both instantiate an HDLcd device. As the presence of the device
can slow down host performances when the software stack is
aware of its presence, we have historically been providing
an entry in the hdlcd DTB node to "hide" the entry from the
DTB parser:

status = "disable";

This default entry in the hdlcd node will in fact prevent the driver
from bringing up the device. Unfortunately this is useful for
experienced users only which are aware of this knob.

In order to make things more transparent, and to avoid any confusion
(e.g. having the hdlcd present in the config.ini, but not being able to
program it in Linux) we are deprecating this solution; we are removing
the HDLcd from the aforementioned platforms.

Users not interested on simulating a display controller won't
notice the difference.
Users interested on including it, will now have to switch to a new

VExpress_GEM5_Vx_HLCD platform

which will enabled the HDLcd without any further tweaking required

JIRA: https://gem5.atlassian.net/browse/GEM5-866

Change-Id: I4b1920efe764080115a57f52d8a3df2e6e2386a0
Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/38796
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Maintainer: Andreas Sandberg <andreas.sandberg@arm.com>
This commit is contained in:
Giacomo Travaglini
2021-01-04 13:36:55 +00:00
parent 642671b29d
commit 1ce08f1655
4 changed files with 66 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
system/arm/dt/Makefile
View File

@@ -1,4 +1,4 @@
# Copyright (c) 2015-2016, 2019-2020 ARM Limited
# Copyright (c) 2015-2016, 2019-2021 ARM Limited
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
@@ -36,21 +36,34 @@ CREATE_TARGET=$(foreach n, $(NUM_CPUS), $(1)_$(n)cpu.dtb)
TARGET_PREFIX=\
armv7_gem5_v1 \
armv8_gem5_v1 \
armv8_gem5_v2
armv8_gem5_v2 \
armv7_gem5_v1_hdlcd \
armv8_gem5_v1_hdlcd \
armv8_gem5_v2_hdlcd
TARGETS=\
$(foreach prefix, $(TARGET_PREFIX), $(call CREATE_TARGET, $(prefix))) \
armv8_gem5_v1_big_little_2_2.dtb \
armv8_gem5_v1_big_little_2_4.dtb \
armv8_gem5_v2_big_little_2_2.dtb \
armv8_gem5_v2_big_little_2_4.dtb
armv8_gem5_v2_big_little_2_4.dtb \
armv8_gem5_v1_hdlcd_big_little_2_2.dtb \
armv8_gem5_v1_hdlcd_big_little_2_4.dtb \
armv8_gem5_v2_hdlcd_big_little_2_2.dtb \
armv8_gem5_v2_hdlcd_big_little_2_4.dtb
VEXPRESS_GEM5_V1_DTSIS=\
platforms/vexpress_gem5_v1.dtsi \
platforms/vexpress_gem5_v1_base.dtsi
VEXPRESS_GEM5_V1_HDLCD_DTSIS=\
platforms/vexpress_gem5_v1_hdlcd.dtsi \
platforms/vexpress_gem5_v1_base.dtsi
VEXPRESS_GEM5_V2_DTSIS=\
platforms/vexpress_gem5_v2.dtsi \
platforms/vexpress_gem5_v2_base.dtsi
VEXPRESS_GEM5_V2_HDLCD_DTSIS=\
platforms/vexpress_gem5_v2_hdlcd.dtsi \
platforms/vexpress_gem5_v2_base.dtsi
GEN_DTS=mkdir -p .gen; \
@@ -62,22 +75,45 @@ GEN_DTS=mkdir -p .gen; \
all: $(TARGETS)
.gen/armv7_gem5_v1_%cpu.dts: armv7.dts $(VEXPRESS_GEM5_V1_DTSIS)
$(call GEN_DTS,vexpress_gem5_v1.dtsi,$*)
.gen/armv7_gem5_v1_%cpu.dts: armv7.dts \
$(VEXPRESS_GEM5_V1_DTSIS)
$(call GEN_DTS,vexpress_gem5_v1_base.dtsi,$*)
.gen/armv8_gem5_v1_%cpu.dts: armv8.dts $(VEXPRESS_GEM5_V1_DTSIS)
$(call GEN_DTS,vexpress_gem5_v1.dtsi,$*)
.gen/armv7_gem5_v1_hdlcd_%cpu.dts: armv7.dts \
$(VEXPRESS_GEM5_V1_HDLCD_DTSIS)
$(call GEN_DTS,vexpress_gem5_v1_hdlcd.dtsi,$*)
.gen/armv8_gem5_v2_%cpu.dts: armv8.dts $(VEXPRESS_GEM5_V2_DTSIS)
$(call GEN_DTS,vexpress_gem5_v2.dtsi,$*)
.gen/armv8_gem5_v1_%cpu.dts: armv8.dts \
$(VEXPRESS_GEM5_V1_DTSIS)
$(call GEN_DTS,vexpress_gem5_v1_base.dtsi,$*)
.gen/armv8_gem5_v1_hdlcd_%cpu.dts: armv8.dts \
$(VEXPRESS_GEM5_V1_HDLCD_DTSIS)
$(call GEN_DTS,vexpress_gem5_v1_hdlcd.dtsi,$*)
.gen/armv8_gem5_v2_%cpu.dts: armv8.dts \
$(VEXPRESS_GEM5_V2_DTSIS)
$(call GEN_DTS,vexpress_gem5_v2_base.dtsi,$*)
.gen/armv8_gem5_v2_hdlcd_%cpu.dts: armv8.dts \
$(VEXPRESS_GEM5_V2_HDLCD_DTSIS)
$(call GEN_DTS,vexpress_gem5_v2_hdlcd.dtsi,$*)
.gen/armv8_gem5_v1_big_little%.dts: armv8_big_little.dts \
$(VEXPRESS_GEM5_V1_DTSIS)
$(call GEN_DTS,vexpress_gem5_v1.dtsi,$*)
$(call GEN_DTS,vexpress_gem5_v1_base.dtsi,$*)
.gen/armv8_gem5_v1_hdlcd_big_little%.dts: armv8_big_little.dts \
$(VEXPRESS_GEM5_V1_HDLCD_DTSIS)
$(call GEN_DTS,vexpress_gem5_v1_hdlcd.dtsi,$*)
.gen/armv8_gem5_v2_big_little%.dts: armv8_big_little.dts \
$(VEXPRESS_GEM5_V2_DTSIS)
$(call GEN_DTS,vexpress_gem5_v2.dtsi,$*)
$(call GEN_DTS,vexpress_gem5_v2_base.dtsi,$*)
.gen/armv8_gem5_v2_hdlcd_big_little%.dts: armv8_big_little.dts \
$(VEXPRESS_GEM5_V2_HDLCD_DTSIS)
$(call GEN_DTS,vexpress_gem5_v2_hdlcd.dtsi,$*)
%.dtb: .gen/%.dts
$(DTC) -I dts -O dtb -o $@ $<

0
system/arm/dt/platforms/vexpress_gem5_v1.dtsi → system/arm/dt/platforms/vexpress_gem5_v1_hdlcd.dtsi
View File

0
system/arm/dt/platforms/vexpress_gem5_v2.dtsi → system/arm/dt/platforms/vexpress_gem5_v2_hdlcd.dtsi
View File