From 1b5d92ee9c00ed4efd4e3d098b316bc1aa30d4b2 Mon Sep 17 00:00:00 2001 From: Minje Jun Date: Wed, 31 Jan 2024 13:42:32 +0900 Subject: [PATCH] mem-ruby: Revert Writeback CHI UD_RU line at local evict This reverts commit d613d814a431525e122552a667eed653a057f2be. Change-Id: I50e218b7debf3a2836ce12515d8fcb6c0b38df53 --- src/mem/ruby/protocol/chi/CHI-cache-funcs.sm | 8 ++++---- src/mem/ruby/protocol/chi/CHI-cache-transitions.sm | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mem/ruby/protocol/chi/CHI-cache-funcs.sm b/src/mem/ruby/protocol/chi/CHI-cache-funcs.sm index ccef1d8deb..fbafda61cd 100644 --- a/src/mem/ruby/protocol/chi/CHI-cache-funcs.sm +++ b/src/mem/ruby/protocol/chi/CHI-cache-funcs.sm @@ -892,10 +892,10 @@ void copyCacheAndDir(CacheEntry cache_entry, DirEntry dir_entry, if (is_valid(cache_entry) && ((initialState == State:UD) || (initialState == State:SD) || (initialState == State:UC) || (initialState == State:SC) || - (initialState == State:UD_RU) || (initialState == State:UD_RSC) || - (initialState == State:SD_RSC) || (initialState == State:UC_RSC) || - (initialState == State:SC_RSC) || (initialState == State:UD_RSD) || - (initialState == State:SD_RSD) || (initialState == State:UD_T))) { + (initialState == State:UD_RSC) || (initialState == State:SD_RSC) || + (initialState == State:UC_RSC) || (initialState == State:SC_RSC) || + (initialState == State:UD_RSD) || (initialState == State:SD_RSD) || + (initialState == State:UD_T))) { tbe.dataBlk := cache_entry.DataBlk; tbe.dataBlkValid.fillMask(); tbe.dataValid := true; diff --git a/src/mem/ruby/protocol/chi/CHI-cache-transitions.sm b/src/mem/ruby/protocol/chi/CHI-cache-transitions.sm index b2cb419833..31b5b0914a 100644 --- a/src/mem/ruby/protocol/chi/CHI-cache-transitions.sm +++ b/src/mem/ruby/protocol/chi/CHI-cache-transitions.sm @@ -710,10 +710,10 @@ transition({UD_RSC, UC_RSC, SC_RSC, SD_RSC, UD, RU, RSD, RUSD, RUSC, UD_RSD, SD_ // Cache Replacement -// When in UC_RU,UD_RSD,SD_RSD we also just drop the line since an upstream +// When in UD_RU,UC_RU,UD_RSD,SD_RSD we also just drop the line since an upstream // cache has an up-to-data line that it will either WriteBack or WriteEvict transition({SC,UC,SC_RSC,UC_RSC, - UC_RU,UD_RSD,SD_RSD}, LocalHN_Eviction, BUSY_BLKD) {ReplTBEAvailable} { + UD_RU,UC_RU,UD_RSD,SD_RSD}, LocalHN_Eviction, BUSY_BLKD) {ReplTBEAvailable} { Initiate_Replacement; Initiate_Replacement_JustDrop; Profile_Eviction; @@ -722,7 +722,7 @@ transition({SC,UC,SC_RSC,UC_RSC, ProcessNextState; } -transition({UD,SD,UD_RU,UD_RSC,SD_RSC}, LocalHN_Eviction, BUSY_BLKD) {ReplTBEAvailable} { +transition({UD,SD,UD_RSC,SD_RSC}, LocalHN_Eviction, BUSY_BLKD) {ReplTBEAvailable} { Initiate_Replacement; Initiate_Replacement_WB; Profile_Eviction; @@ -749,7 +749,7 @@ transition({UD,SD,UC}, Local_Eviction, BUSY_BLKD) {ReplTBEAvailable} { ProcessNextState; } -transition({UC_RU,UD_RSD,SD_RSD,SC_RSC,UC_RSC}, Local_Eviction, BUSY_BLKD) {ReplTBEAvailable} { +transition({UD_RU,UC_RU,UD_RSD,SD_RSD,SC_RSC,UC_RSC}, Local_Eviction, BUSY_BLKD) {ReplTBEAvailable} { Initiate_Replacement; Initiate_Replacement_JustDrop; Profile_Eviction; @@ -758,7 +758,7 @@ transition({UC_RU,UD_RSD,SD_RSD,SC_RSC,UC_RSC}, Local_Eviction, BUSY_BLKD) {Repl ProcessNextState; } -transition({UD_RU,UD_RSC,SD_RSC}, Local_Eviction, BUSY_BLKD) {ReplTBEAvailable} { +transition({UD_RSC,SD_RSC}, Local_Eviction, BUSY_BLKD) {ReplTBEAvailable} { Initiate_Replacement; Initiate_Replacement_WB; Profile_Eviction;