derek/gem5
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cpu: Remove duplicated fetch stats

Browse Source 
This removes numFetchSuspends and duplicates numBranches calls
so we only have the updated fetch stats outputting.

Change-Id: Ia7a6830ee947f5c67386dd1e6e3db1744a7ee43c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69105
Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu>
Maintainer: Bobby Bruce <bbruce@ucdavis.edu>
Tested-by: kokoro <noreply+kokoro@google.com>
This commit is contained in:
Melissa Jost
2023-03-20 00:01:53 -07:00
committed by Bobby Bruce
parent a882373e82
commit 19323c8bd7
5 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/cpu/minor/execute.cc
View File

@@ -1062,8 +1062,6 @@ Execute::commitInst(MinorDynInstPtr inst, bool early_memory_issue,
DPRINTF(MinorInterrupt, "Suspending thread: %d from Execute"
" inst: %s\n", thread_id, *inst);
// output both old and new stats
cpu.stats.numFetchSuspends++;
cpu.fetchStats[thread_id]->numFetchSuspends++;
updateBranchData(thread_id, BranchData::SuspendThread, inst,

2
src/cpu/minor/stats.cc
View File

@@ -52,8 +52,6 @@ MinorStats::MinorStats(BaseCPU *base_cpu)
ADD_STAT(numDiscardedOps, statistics::units::Count::get(),
"Number of ops (including micro ops) which were discarded before "
"commit"),
ADD_STAT(numFetchSuspends, statistics::units::Count::get(),
"Number of times Execute suspended instruction fetching"),
ADD_STAT(quiesceCycles, statistics::units::Cycle::get(),
"Total number of cycles that CPU has spent quiesced or waiting "
"for an interrupt"),

3
src/cpu/minor/stats.hh
View File

@@ -68,9 +68,6 @@ struct MinorStats : public statistics::Group
/** Number of ops discarded before committing */
statistics::Scalar numDiscardedOps;
/** Number of times fetch was asked to suspend by Execute */
statistics::Scalar numFetchSuspends;
/** Number of cycles in quiescent state */
statistics::Scalar quiesceCycles;

2
src/cpu/simple/base.cc
View File

@@ -431,8 +431,6 @@ BaseSimpleCPU::postExecute()
}
if (curStaticInst->isControl()) {
// output both old and new stats
++t_info.execContextStats.numBranches;
++fetchStats[t_info.thread->threadId()]->numBranches;
}

7
src/cpu/simple/exec_context.hh
View File

@@ -152,8 +152,6 @@ class SimpleExecContext : public ExecContext
"ICache total stall cycles"),
ADD_STAT(dcacheStallCycles, statistics::units::Cycle::get(),
"DCache total stall cycles"),
ADD_STAT(numBranches, statistics::units::Count::get(),
"Number of branches fetched"),
ADD_STAT(numPredictedBranches, statistics::units::Count::get(),
"Number of branches predicted as taken"),
ADD_STAT(numBranchMispred, statistics::units::Count::get(),
@@ -204,9 +202,6 @@ class SimpleExecContext : public ExecContext
numIdleCycles = idleFraction * cpu->baseStats.numCycles;
numBusyCycles = notIdleFraction * cpu->baseStats.numCycles;
numBranches
.prereq(numBranches);
numPredictedBranches
.prereq(numPredictedBranches);
@@ -298,8 +293,6 @@ class SimpleExecContext : public ExecContext
statistics::Scalar dcacheStallCycles;
/// @{
/// Total number of branches fetched
statistics::Scalar numBranches;
/// Number of branches predicted as taken
statistics::Scalar numPredictedBranches;
/// Number of misprediced branches