From 0c20eb3ec7015ba503047d650822f28c69273811 Mon Sep 17 00:00:00 2001 From: Giacomo Travaglini Date: Wed, 21 Feb 2024 13:29:47 +0000 Subject: [PATCH] arch-arm: Call finalizePhysical even when MMU is off The finalizePhysical is just checking if the physical address falls within the m5op region (if using mmapped m5ops). There's not reason why we shouldn't enable it with virtual memory off Change-Id: I5ab80fd4e7886743abd4b7d85937b72253b578d3 Signed-off-by: Giacomo Travaglini Reviewed-by: Andreas Sandberg Reviewed-by: Richard Cooper --- src/arch/arm/mmu.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/arch/arm/mmu.cc b/src/arch/arm/mmu.cc index 6c4659dbd1..66e0bfe63f 100644 --- a/src/arch/arm/mmu.cc +++ b/src/arch/arm/mmu.cc @@ -848,7 +848,12 @@ MMU::translateMmuOff(ThreadContext *tc, const RequestPtr &req, Mode mode, state.isStage2); setAttr(temp_te.attributes); - return testTranslation(req, mode, TlbEntry::DomainType::NoAccess, state); + Fault fault = testTranslation(req, mode, TlbEntry::DomainType::NoAccess, state); + if (fault == NoFault) { + return finalizePhysical(req, tc, mode); + } else { + return fault; + } } Fault