style: eliminate equality tests with true and false

Using '== true' in a boolean expression is totally redundant,
and using '== false' is pretty verbose (and arguably less
readable in most cases) compared to '!'.

It's somewhat of a pet peeve, perhaps, but I had some time
waiting for some tests to run and decided to clean these up.

Unfortunately, SLICC appears not to have the '!' operator,
so I had to leave the '== false' tests in the SLICC code.
This commit is contained in:
Steve Reinhardt
2014-05-31 18:00:23 -07:00
parent 2a8088f5ae
commit 0be64ffe2f
24 changed files with 49 additions and 50 deletions

View File

@@ -104,7 +104,7 @@ HexFile::parseLine(char *Str, Addr *A, uint32_t *D)
} else if (Str[i] == ' ' || Str[i] == '\n') {
if (Number == 0)
return;
if (Flag == false) {
if (!Flag) {
*A = Number;
Number = 0;
Flag = true;
@@ -125,7 +125,7 @@ HexFile::parseLine(char *Str, Addr *A, uint32_t *D)
i++;
}
if (Flag != true) {
if (!Flag) {
*A = 0;
*D = 0;
} else {

View File

@@ -89,7 +89,7 @@ ObjectMatch::domatch(const string &name) const
}
}
if (match == true)
if (match)
return true;
}