From 0a9dfbb8da1a8d63598385d6e2c8bc785892852f Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Mon, 18 Jan 2021 01:47:53 -0800 Subject: [PATCH] arch: Remove copyMiscRegs from utility.hh. This function is occasionally used internally in copyRegs, but is not used by anything else and doesn't need to be publically exposed in the header file. Change-Id: Id02a77e7dd19c6c089a408bfe0099466822c523d Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39325 Reviewed-by: Daniel Carvalho Maintainer: Gabe Black Tested-by: kokoro --- src/arch/arm/utility.hh | 6 ------ src/arch/mips/utility.cc | 6 ------ src/arch/mips/utility.hh | 1 - src/arch/power/utility.cc | 6 +++--- src/arch/power/utility.hh | 5 ----- src/arch/sparc/utility.hh | 2 -- src/arch/x86/utility.hh | 2 -- 7 files changed, 3 insertions(+), 25 deletions(-) diff --git a/src/arch/arm/utility.hh b/src/arch/arm/utility.hh index d38433e93a..5b3b849b43 100644 --- a/src/arch/arm/utility.hh +++ b/src/arch/arm/utility.hh @@ -87,12 +87,6 @@ testPredicate(uint32_t nz, uint32_t c, uint32_t v, ConditionCode code) void copyRegs(ThreadContext *src, ThreadContext *dest); -static inline void -copyMiscRegs(ThreadContext *src, ThreadContext *dest) -{ - panic("Copy Misc. Regs Not Implemented Yet\n"); -} - /** Send an event (SEV) to a specific PE if there isn't * already a pending event */ void sendEvent(ThreadContext *tc); diff --git a/src/arch/mips/utility.cc b/src/arch/mips/utility.cc index 911756f5fa..a0c671ff2a 100644 --- a/src/arch/mips/utility.cc +++ b/src/arch/mips/utility.cc @@ -224,10 +224,4 @@ copyRegs(ThreadContext *src, ThreadContext *dest) dest->pcState(src->pcState()); } -void -copyMiscRegs(ThreadContext *src, ThreadContext *dest) -{ - panic("Copy Misc. Regs Not Implemented Yet\n"); -} - } // namespace MipsISA diff --git a/src/arch/mips/utility.hh b/src/arch/mips/utility.hh index eb7f74a914..1804680078 100644 --- a/src/arch/mips/utility.hh +++ b/src/arch/mips/utility.hh @@ -73,7 +73,6 @@ RoundPage(Addr addr) } void copyRegs(ThreadContext *src, ThreadContext *dest); -void copyMiscRegs(ThreadContext *src, ThreadContext *dest); inline void advancePC(PCState &pc, const StaticInstPtr &inst) diff --git a/src/arch/power/utility.cc b/src/arch/power/utility.cc index 1c68cd9735..ffcbe4ffb4 100644 --- a/src/arch/power/utility.cc +++ b/src/arch/power/utility.cc @@ -32,7 +32,8 @@ #include "base/logging.hh" -namespace PowerISA { +namespace PowerISA +{ void copyRegs(ThreadContext *src, ThreadContext *dest) @@ -45,8 +46,7 @@ copyRegs(ThreadContext *src, ThreadContext *dest) for (int i = 0; i < NumFloatRegs; ++i) dest->setFloatReg(i, src->readFloatReg(i)); - // Copy misc. registers - copyMiscRegs(src, dest); + //TODO Copy misc. registers. // Lastly copy PC/NPC dest->pcState(src->pcState()); diff --git a/src/arch/power/utility.hh b/src/arch/power/utility.hh index 7c892d4110..03df7fb6de 100644 --- a/src/arch/power/utility.hh +++ b/src/arch/power/utility.hh @@ -39,11 +39,6 @@ namespace PowerISA { void copyRegs(ThreadContext *src, ThreadContext *dest); -static inline void -copyMiscRegs(ThreadContext *src, ThreadContext *dest) -{ -} - inline void advancePC(PCState &pc, const StaticInstPtr &inst) { diff --git a/src/arch/sparc/utility.hh b/src/arch/sparc/utility.hh index e61989a8f7..f179c1751b 100644 --- a/src/arch/sparc/utility.hh +++ b/src/arch/sparc/utility.hh @@ -43,8 +43,6 @@ namespace SparcISA void copyRegs(ThreadContext *src, ThreadContext *dest); -void copyMiscRegs(ThreadContext *src, ThreadContext *dest); - inline void advancePC(PCState &pc, const StaticInstPtr &inst) { diff --git a/src/arch/x86/utility.hh b/src/arch/x86/utility.hh index a7c2dfccb7..9cd4e943c0 100644 --- a/src/arch/x86/utility.hh +++ b/src/arch/x86/utility.hh @@ -46,8 +46,6 @@ namespace X86ISA { void copyRegs(ThreadContext *src, ThreadContext *dest); - void copyMiscRegs(ThreadContext *src, ThreadContext *dest); - inline void advancePC(PCState &pc, const StaticInstPtr &inst) {