sim-se: Refactor clone to avoid most ifdefs

Some parts of clone are architecture dependent. In some cases, we are
able to use architecture-specific helper functions or register
aliases. However, there is still some architecture-specific that is
protected by ifdefs in the common clone implementation.

Move these architecture-specific bits to the architecture-specific OS
class instead to avoid these ifdefs and make the code a bit more
readable.

Change-Id: Ia0903d738d0ba890863bddfa77e3b717db7f45de
Signed-off-by: Andreas Sandberg <andreas.sandberg@arm.com>
Cc: Giacomo Travaglini <giacomo.travaglini@arm.com>
Cc: Javier Setoain <javier.setoain@arm.com>
Cc: Brandon Potter <Brandon.Potter@amd.com>
Reviewed-on: https://gem5-review.googlesource.com/c/15435
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Brandon Potter <Brandon.Potter@amd.com>
This commit is contained in:
Andreas Sandberg
2019-01-09 14:50:27 +00:00
parent 13daa2e062
commit 0a36956261
6 changed files with 93 additions and 33 deletions

View File

@@ -45,9 +45,26 @@
#ifndef __ARCH_ARM_LINUX_LINUX_HH__
#define __ARCH_ARM_LINUX_LINUX_HH__
#include "arch/arm/utility.hh"
#include "kern/linux/linux.hh"
class ArmLinux32 : public Linux
class ArmLinux : public Linux
{
public:
static void
archClone(uint64_t flags,
Process *pp, Process *cp,
ThreadContext *ptc, ThreadContext *ctc,
uint64_t stack, uint64_t tls)
{
ArmISA::copyRegs(ptc, ctc);
if (stack)
ctc->setIntReg(TheISA::StackPointerReg, stack);
}
};
class ArmLinux32 : public ArmLinux
{
public:
@@ -256,7 +273,7 @@ class ArmLinux32 : public Linux
};
};
class ArmLinux64 : public Linux
class ArmLinux64 : public ArmLinux
{
public: