From c776efbdae810492263bbc9f279266421b80a980 Mon Sep 17 00:00:00 2001 From: Jan Eitzinger Date: Tue, 19 Mar 2019 09:13:01 +0100 Subject: [PATCH] Revert "Merge branch 'MARKERS' of github.com:RRZE-HPC/TheBandwidthBenchmark" This reverts commit 21bedcda407e9d40773a4074da7c071368a79044, reversing changes made to bb19bf5a49e1c31cd28258aa69b1f7e083096caa. --- Makefile | 1 - config.mk | 5 ++-- include_ICC.mk | 2 +- include_LIKWID.mk | 10 -------- src/copy.c | 8 +------ src/daxpy.c | 8 +------ src/includes/likwid_markers.h | 44 ----------------------------------- src/init.c | 8 +------ src/main.c | 13 ----------- src/triad.c | 12 +++------- src/update.c | 8 +------ 11 files changed, 10 insertions(+), 109 deletions(-) delete mode 100644 include_LIKWID.mk delete mode 100644 src/includes/likwid_markers.h diff --git a/Makefile b/Makefile index d687e7e..14d3e8f 100644 --- a/Makefile +++ b/Makefile @@ -9,7 +9,6 @@ Q ?= @ #DO NOT EDIT BELOW include $(MAKE_DIR)/config.mk include $(MAKE_DIR)/include_$(TAG).mk -include $(MAKE_DIR)/include_LIKWID.mk INCLUDES += -I./src/includes VPATH = $(SRC_DIR) diff --git a/config.mk b/config.mk index 7cbeca9..b5c5f15 100644 --- a/config.mk +++ b/config.mk @@ -1,10 +1,9 @@ # Supported: GCC, CLANG, ICC -TAG ?= ICC +TAG ?= GCC ENABLE_OPENMP ?= false -ENABLE_LIKWID ?= false #Feature options -OPTIONS = -DSIZE=100000000ull +OPTIONS = -DSIZE=40000000ull OPTIONS += -DNTIMES=10 OPTIONS += -DARRAY_ALIGNMENT=64 #OPTIONS += -DVERBOSE_AFFINITY diff --git a/include_ICC.mk b/include_ICC.mk index 5ba42bc..dd1cb99 100644 --- a/include_ICC.mk +++ b/include_ICC.mk @@ -5,7 +5,7 @@ ifeq ($(ENABLE_OPENMP),true) OPENMP = -qopenmp endif -CFLAGS = -Ofast -xHost -std=c99 -ffreestanding $(OPENMP) +CFLAGS = -qopt-report -Ofast -xHost -std=c99 -ffreestanding $(OPENMP) LFLAGS = $(OPENMP) DEFINES = -D_GNU_SOURCE INCLUDES = diff --git a/include_LIKWID.mk b/include_LIKWID.mk deleted file mode 100644 index 4ca5456..0000000 --- a/include_LIKWID.mk +++ /dev/null @@ -1,10 +0,0 @@ -LIKWID_INC ?= -I/usr/local/include -LIKWID_DEFINES ?= -DLIKWID_PERFMON -LIKWID_LIB ?= -L/usr/local/lib - -ifeq ($(strip $(ENABLE_LIKWID)),true) -INCLUDES += ${LIKWID_INC} -DEFINES += ${LIKWID_DEFINES} -LIBS += -llikwid -LFLAGS += ${LIKWID_LIB} -endif diff --git a/src/copy.c b/src/copy.c index edf2ecd..7e31a0c 100644 --- a/src/copy.c +++ b/src/copy.c @@ -26,7 +26,6 @@ */ #include -#include double copy( double * restrict a, @@ -37,15 +36,10 @@ double copy( double S, E; S = getTimeStamp(); -#pragma omp parallel -{ - LIKWID_MARKER_START("COPY"); -#pragma omp for +#pragma omp parallel for for (int i=0; i -#include double daxpy( double * restrict a, @@ -38,15 +37,10 @@ double daxpy( double S, E; S = getTimeStamp(); -#pragma omp parallel -{ - LIKWID_MARKER_START("DAXPY"); -#pragma omp for +#pragma omp parallel for for (int i=0; i -#else -#define LIKWID_MARKER_INIT -#define LIKWID_MARKER_THREADINIT -#define LIKWID_MARKER_SWITCH -#define LIKWID_MARKER_REGISTER(regionTag) -#define LIKWID_MARKER_START(regionTag) -#define LIKWID_MARKER_STOP(regionTag) -#define LIKWID_MARKER_CLOSE -#define LIKWID_MARKER_GET(regionTag, nevents, events, time, count) -#endif - -#endif /*LIKWID_MARKERS_H*/ diff --git a/src/init.c b/src/init.c index 904ce72..f2164a8 100644 --- a/src/init.c +++ b/src/init.c @@ -26,7 +26,6 @@ */ #include -#include double init( double * restrict a, @@ -37,15 +36,10 @@ double init( double S, E; S = getTimeStamp(); -#pragma omp parallel -{ - LIKWID_MARKER_START("INIT"); -#pragma omp for +#pragma omp parallel for for (int i=0; i #include #include -#include #define HLINE "----------------------------------------------------------------------------\n" @@ -106,17 +105,6 @@ int main (int argc, char** argv) {"SDaxpy: ", 4, 2} }; - LIKWID_MARKER_INIT; -#ifdef _OPENMP -#pragma omp parallel -{ -#endif - LIKWID_MARKER_REGISTER("INIT"); - LIKWID_MARKER_REGISTER("COPY"); -#ifdef _OPENMP -} -#endif - a = (double*) allocate( ARRAY_ALIGNMENT, N * bytesPerWord ); b = (double*) allocate( ARRAY_ALIGNMENT, N * bytesPerWord ); c = (double*) allocate( ARRAY_ALIGNMENT, N * bytesPerWord ); @@ -212,7 +200,6 @@ int main (int argc, char** argv) printf(HLINE); check(a, b, c, d, N); - LIKWID_MARKER_CLOSE; return EXIT_SUCCESS; } diff --git a/src/triad.c b/src/triad.c index e7336bb..04914be 100644 --- a/src/triad.c +++ b/src/triad.c @@ -26,7 +26,6 @@ */ #include -#include double triad( double * restrict a, @@ -39,14 +38,9 @@ double triad( double S, E; S = getTimeStamp(); -#pragma omp parallel - { - LIKWID_MARKER_START("TRIAD"); -#pragma omp for - for (int i=0; i -#include double update( double * restrict a, @@ -37,15 +36,10 @@ double update( double S, E; S = getTimeStamp(); -#pragma omp parallel -{ - LIKWID_MARKER_START("UPDATE"); -#pragma omp for +#pragma omp parallel for for (int i=0; i