From 9d6ceca4fccfea50c046544f5c16f72b71837fec Mon Sep 17 00:00:00 2001 From: Iron Prando da Silva Date: Thu, 16 Dec 2021 13:58:10 +0100 Subject: [PATCH] Changed command bus dependencies to Inter-Rank. --- .../businessObjects/phasedependenciestracker.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/DRAMSys/traceAnalyzer/businessObjects/phasedependenciestracker.cpp b/DRAMSys/traceAnalyzer/businessObjects/phasedependenciestracker.cpp index aaf0e285..280eb02c 100644 --- a/DRAMSys/traceAnalyzer/businessObjects/phasedependenciestracker.cpp +++ b/DRAMSys/traceAnalyzer/businessObjects/phasedependenciestracker.cpp @@ -186,7 +186,7 @@ PhaseDependenciesTracker::mCalculateDependencies(const TraceDB& tdb, const std:: if ( dep.depType == DependencyType::IntraBank && cmdBank != otherPhase->tBank || dep.depType == DependencyType::IntraRank && cmdRank != otherPhase->tRank - || dep.depType == DependencyType::InterRank && cmdRank == otherPhase->tRank // TODO - is this last comparison correct? + || dep.depType == DependencyType::InterRank && cmdRank == otherPhase->tRank // TODO - is this last comparison correct? Check if this holds on all devices ) { continue; } @@ -233,7 +233,7 @@ PhaseDependenciesTracker::mCalculateDependencies(const TraceDB& tdb, const std:: entries.emplace_back(DBDependencyEntry{ phase->id, phase->phaseName, - PhaseDependency::dependencyTypeName(DependencyType::IntraRank), + PhaseDependency::dependencyTypeName(DependencyType::InterRank), "CommandBus", otherPhase->id, otherPhase->phaseName @@ -242,6 +242,7 @@ PhaseDependenciesTracker::mCalculateDependencies(const TraceDB& tdb, const std:: } + if (nawCount >= device->getNAW()) { entries.insert( entries.end(), tmpPotentialNAW.begin(), tmpPotentialNAW.end() ); }