From 9b5ed54138370d5225b95c06a64d3dc45d50b423 Mon Sep 17 00:00:00 2001
From: robert <robertgernha@gmail.com>
Date: Mon, 21 Apr 2014 09:55:37 +0200
Subject: [PATCH] addressmappings tested

---
 dram/resources/configs/amconfigs/am_highHits.xml | 2 +-
 dram/resources/configs/amconfigs/am_highPara.xml | 3 ++-
 dram/resources/configs/amconfigs/am_lowHits.xml  | 3 +--
 dram/resources/configs/amconfigs/am_lowPara.xml  | 2 +-
 dram/src/simulation/SimulationManager.cpp        | 4 ++--
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/dram/resources/configs/amconfigs/am_highHits.xml b/dram/resources/configs/amconfigs/am_highHits.xml
index d650c313..4a724150 100644
--- a/dram/resources/configs/amconfigs/am_highHits.xml
+++ b/dram/resources/configs/amconfigs/am_highHits.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
-<!-- highest hit rate  -->
+<!-- should have highest hit rate, since a (row, bank) bank pair changes infrequently -->
 <dramconfig>
 <addressmap length="32">
 		<row   from="19" to="31" />		
diff --git a/dram/resources/configs/amconfigs/am_highPara.xml b/dram/resources/configs/amconfigs/am_highPara.xml
index b2437729..20855861 100755
--- a/dram/resources/configs/amconfigs/am_highPara.xml
+++ b/dram/resources/configs/amconfigs/am_highPara.xml
@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
-<!-- highest bank parallelism - high hits -->
+<!-- should have high bank parallelism with good row hit rate, since bank bits have the 
+	 highest entropy and row bits the lowest -->
  <dramconfig>
 	<addressmap length="32">
 		<row   from="19" to="31" />		
diff --git a/dram/resources/configs/amconfigs/am_lowHits.xml b/dram/resources/configs/amconfigs/am_lowHits.xml
index ef34b0bc..d54cd0b3 100755
--- a/dram/resources/configs/amconfigs/am_lowHits.xml
+++ b/dram/resources/configs/amconfigs/am_lowHits.xml
@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
 
-<!-- highest bank parallism - low hits
- -->
+<!-- should have high bank parallelism with a low hit rate -->
  <dramconfig>
 	<addressmap length="32">
 		<colum   from="24" to="31" />		
diff --git a/dram/resources/configs/amconfigs/am_lowPara.xml b/dram/resources/configs/amconfigs/am_lowPara.xml
index fb7d1478..eb363f82 100755
--- a/dram/resources/configs/amconfigs/am_lowPara.xml
+++ b/dram/resources/configs/amconfigs/am_lowPara.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
 
-<!--  low bank parallelism - high hits -->
+<!-- should have low bank parallelism and a high hit rate -->
 <dramconfig>
 	<addressmap length="32">
 		<bank   from="30" to="31" />		
diff --git a/dram/src/simulation/SimulationManager.cpp b/dram/src/simulation/SimulationManager.cpp
index bdf4ac95..027b151e 100644
--- a/dram/src/simulation/SimulationManager.cpp
+++ b/dram/src/simulation/SimulationManager.cpp
@@ -68,8 +68,8 @@ void SimulationManager::runSimulations()
 			for (auto& traceSetup : batch.traceSetups)
 			{
 				runSimulation(
-						exportPath + "/" + batch.simulationName + "/" + traceSetup.first + "-" + memconfig + "-" + memspec + "-" +
-								addressmappig + ".tdb", dramSetup, traceSetup.second);
+						exportPath + "/" + batch.simulationName + "/" + traceSetup.first + "-" + addressmappig  + "-" +
+								  memconfig + ".tdb", dramSetup, traceSetup.second);
 			}
 		}
 	}