From 968eceb620ebbde052eed50cf9931aef189c35d4 Mon Sep 17 00:00:00 2001 From: scorrea Date: Mon, 11 May 2020 16:36:19 +0200 Subject: [PATCH] comments removed --- DRAMSys/library/src/common/AddressDecoder.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/DRAMSys/library/src/common/AddressDecoder.cpp b/DRAMSys/library/src/common/AddressDecoder.cpp index 82d28092..69a0aa3f 100644 --- a/DRAMSys/library/src/common/AddressDecoder.cpp +++ b/DRAMSys/library/src/common/AddressDecoder.cpp @@ -47,7 +47,7 @@ unsigned int AddressDecoder::getUnsignedAttrFromJson(nlohmann::json obj, std::st } return vParameter; -} /// TODO:Rewrite with break instead +} AddressDecoder::AddressDecoder(std::string pathToAddressMapping) { @@ -75,17 +75,12 @@ AddressDecoder::AddressDecoder(std::string pathToAddressMapping) vRowBits = getAttrToVectorFromJson(j,"ROW_BIT"); vColumnBits = getAttrToVectorFromJson(j,"COLUMN_BIT"); vByteBits = getAttrToVectorFromJson(j,"BYTE_BIT"); - //if it doesnt have one of them it returns "not a number :(" } - //TODO find a way to generate an error if it doesnt find an object with ID==0. } + if (ID != true) SC_REPORT_FATAL("AddressDecoder", "No mapping with ID 0 was found."); - - //Why to have several "SOLUTION" elements if only the one with ID=0 will be used???? - - unsigned channels = pow(2.0, vChannelBits.size()); unsigned ranks = pow(2.0, vRankBits.size()); unsigned bankgroups = pow(2.0, vBankGroupBits.size());